Infra: Use the standard shadow plugin #7681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
approved these changes
May 22, 2023
Fokko
approved these changes
May 22, 2023
|
Thanks for the review. The build has passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
I tried to bump the Nessie version, which brought the latest Jackson 2.15.x dependency.
With this, runtime uber jar building is failing as Jackson 2.15.x is multi-version jar (packs classes of Java 19 also).
After debugging, found that the problem is in shadow jar plugin that Iceberg is using(which also looks fishy with just one release) and with the standard shadow jar plugin the build can pass even with multi-version jars.