-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Add initial TableScan implementation #6145
Conversation
): | ||
self.table = table | ||
self.row_filter = row_filter or AlwaysTrue() | ||
self.partition_filter = partition_filter or AlwaysTrue() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, except that it left out the scan refinement methods. I think those should be included so you can use the same refinement strategy that the JVM API supports.
ff54ae3
to
aa078de
Compare
Also threw in some tests 👍🏻 |
Thanks, @Fokko! |
This adds an implementation of TableScan that is an alternative to the one in #6131. This doesn't implement plan_files, it is just to demonstrate a possible scan API: