Fix typo in _ManifestEvalVisitor.visit_equal
#6117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajantha-bhat
reviewed
Nov 4, 2022
| @@ -526,7 +526,7 @@ def visit_equal(self, term: BoundTerm, literal: Literal[Any]) -> bool: | |||
| if lower > literal.value: | |||
| return ROWS_CANNOT_MATCH | |||
|
|
|||
| upper = _from_byte_buffer(term.ref().field.field_type, field.lower_bound) | |||
| upper = _from_byte_buffer(term.ref().field.field_type, field.upper_bound) | |||
There was a problem hiding this comment.
good finding 👍🏻.
nit: maybe good to have unit tests around these.
|
I reopened this because I think it's a good idea to get it in independently. Thanks for finding this, @ddrinka! |
|
Fixed the linting issue, thanks @ddrinka! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Fokko here's another runtime bug I'm seeing while playing with this new Manifest evaluator (#5845)