-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only run publish GH action for apache repo, not forked #3500
Only run publish GH action for apache repo, not forked #3500
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good catch. Thank you @kevinjqliu!
cc @nastra who authored this action. Do you have the need to be able to run this action in your fork (where editing this out and pushing it into your fork's master branch wouldn't be a viable work around)?
EDIT: Also, this might be somewhat urgent if somebody's fork does have permissions (which would be surprising but you never know).
I merged this change to my own fork. Seems like it runs on 0 UTC, will report back tmr |
@kbendick no I don't need to have this enabled in my own fork, so let's get this merged. @kevinjqliu thanks for bringing this up. |
Agreed let’s get this merged ASAP. Feel free to ask @rymurr to merge this since y’all are up. If he’s not available. I’m OOO for much of the day tomorrow but I’ll ask somebody in me timezone otherwise. This seems pretty important. We should also consider locking down the permissions of this particular job (and eventually all of them). Take a look at the labeler workflow that I added permissions to a while back @nastra. |
@rymurr , One small piece of advice: Pls check if the commit message are formatted like |
Thanks, @rymurr for merging! Good to see you again. |
Co-authored-by: Kevin Liu <[email protected]>
The
Publish Snapshot to Maven
Github Action has been scheduled automatically in my forked repo and failing due to permission issues.Log:
Example GH Action run
The GH Action retries automatically (every day?) and will also generate a failure email report. I had to manually disable it on my forked repo.
This PR limits the GH Action to run only on the
apache
repo.References: