Build: Exclude zstd-jni from iceberg-spark3-runtime #3058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
changed the title
kbendick
approved these changes
Aug 31, 2021
|
cc @RussellSpitzer, please take a look if you have time. |
|
Confirming what @kbendick said we made this change internally a while back. If everyone else is ok with it I think we should remove the library but this is the kind of change I think we need more folks to check out before we merge just incase we are missing someone's prod usage. @rdblue + @jackye1995 + @openinx |
|
Sounds good to me. |
rdblue
approved these changes
Sep 2, 2021
|
@jackye1995 would u pls take a look as well? |
|
Thanks, @pan3793! I went ahead and merged this since it's been a few days without comment. |
|
I added this to 0.13.0 milestone as it appears it didn't ship with 0.12.1. I'm not sure if this merits a patch release to 0.12.2... I'd say since we're in progress towards 0.13.0 that it would be easier to hold off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spark-corealready has the dependencyzstd-jni, it should be exclude fromiceberg-spark3-runtime.