Auth Manager API part 5: SigV4 Auth Manager #11995
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adutra
force-pushed
the
auth-manager-5-final
branch
from
372fd66 to
5aaa81e
Compare
adutra
force-pushed
the
auth-manager-5-final
branch
from
5aaa81e to
79f3917
Compare
|
The flink test failure seems unrelated. I will try to trigger a new run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5th PR for the Auth Manager API. Previous ones:
This PR introduces the SigV4 auth manager. It can be reviewed independently of part4.
The peculiarity of the SIgV4 manager is that it takes a delegate auth manager. IOW, it is able to first delegate authentication to some other auth manager (by default, OAuth2), then sign the request, potentially relocating the authorization header introduced by the delegate manager. This is the current behavior of SigV4 signing.
Contrary to what I said earlier on the dev list, the SigV4 manager at this stage is still "unplugged". Merging this PR is completely harmless.
The old
RESTSigV4Signeris still there and active, its contents can be compared with those of the newRESTSigV4AuthSessionthat will replace it soon.\cc @nastra @danielcweeks