Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] support table scan in iceberg python library #3229

Closed
jun-he opened this issue Oct 6, 2021 · 7 comments
Closed

[Python] support table scan in iceberg python library #3229

jun-he opened this issue Oct 6, 2021 · 7 comments
Assignees
Labels

Comments

@jun-he
Copy link
Collaborator

jun-he commented Oct 6, 2021

This task is to implement table scan function in iceberg/python library. There is an implementation in iceberg/python_legacy library. Please review it and then either update it or rewrite it.

@jun-he jun-he added the python label Oct 6, 2021
@jun-he jun-he added this to the Python 0.1.0 release milestone Oct 6, 2021
@geekusa33
Copy link

would this issue be updating the python legacy table scan code in the iceberg/python directory?

@jun-he
Copy link
Collaborator Author

jun-he commented Oct 6, 2021

Yep, let me add some details in the description.

@geekusa33
Copy link

@jun-he could I try and complete this?

Assuming goes well, would likely try taking in some of the others.

Wanting to complete as part of hacktoberfest

@jun-he
Copy link
Collaborator Author

jun-he commented Oct 7, 2021

Hi @askalik, thanks for the help. I assign this task to you.

@Fokko
Copy link
Contributor

Fokko commented Sep 21, 2022

I'll bump this to the next release 👍🏻

@simjay
Copy link

simjay commented Oct 26, 2022

Hi @jun-he, I was on the monthly sync today and heard you might want to revisit this task and I am interested. I want to take a stab at it but if you could give any pointer for me to understand the how you want the refactor to be done, it would be amazing.

For now, I read the legacy_python's DataTableScan implementation and currently trying to understand more on how this repo is structured. Any guidance or more details would be much appreciated, so that potentially i can contribute to this ticket!

dhruv-pratap added a commit to dhruv-pratap/iceberg that referenced this issue Oct 27, 2022
@Fokko
Copy link
Contributor

Fokko commented Nov 28, 2022

This is in: #6233

@Fokko Fokko closed this as completed Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants