Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add rust-cache action #844

Merged
merged 1 commit into from
Dec 27, 2024
Merged

ci: add rust-cache action #844

merged 1 commit into from
Dec 27, 2024

Conversation

xxchan
Copy link
Contributor

@xxchan xxchan commented Dec 25, 2024

alternative to #824

@xxchan
Copy link
Contributor Author

xxchan commented Dec 25, 2024

image

It performs much better than sccache (#824 (comment))

cc @liurenjie1024 @Fokko @Xuanwo @kevinjqliu

@xxchan xxchan mentioned this pull request Dec 26, 2024
@Xuanwo
Copy link
Member

Xuanwo commented Dec 26, 2024

Hi, as mentioned in #849 (comment), I'm fine with checking in Cargo.lock. Would you like to split this PR into two? One for checking in the lock file and the other for adding rust-cache.

I apologize for this request since the change is really small. However, I genuinely want to make the history clearer and more readable.

@xxchan
Copy link
Contributor Author

xxchan commented Dec 26, 2024

Done: #851

@xxchan xxchan force-pushed the xxchan/rust-cache branch 2 times, most recently from 2647e98 to 4d0e83e Compare December 27, 2024 07:18
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @xxchan for building this, let's move.

@Xuanwo Xuanwo merged commit 91980aa into apache:main Dec 27, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants