Disallow default header to be overwritten #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whynick1
commented
Apr 3, 2024
| "rest", | ||
| uri=TEST_URI, | ||
| warehouse="s3://some-bucket", | ||
| **{"header.Content-Type": "application/vnd.api+json", "header.Customized-Header": "some/value"}, |
There was a problem hiding this comment.
Ensure custom header is still supported, meanwhile disallow default headers, such as Content-Type to be overwritten. Same for the test below.
|
@flyrain @liurenjie1024 Can you take a look please. Thanks. |
|
@Fokko, do you wanna take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve #550.