-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort Order update #476
Sort Order update #476
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, can you check the tests and CI? make install && make lint
Co-authored-by: Fokko Driesprong <[email protected]>
My bad, missed it this time. Fixed in the latest revision |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor suggestions, but apart from that it looks good 👍
* Implement sort order update * Cleanup * Add test * Add test * Update pyiceberg/table/metadata.py Co-authored-by: Fokko Driesprong <[email protected]> * Lint * Nits * Nits --------- Co-authored-by: Fokko Driesprong <[email protected]>
Adds ability to add and update the default sort order via
update_table_metadata