-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Daft examples and code into PyIceberg docs and Table #355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good @jaychia
pyproject.toml
Outdated
@@ -105,6 +105,7 @@ pyarrow = ["pyarrow"] | |||
pandas = ["pandas", "pyarrow"] | |||
duckdb = ["duckdb", "pyarrow"] | |||
ray = ["ray", "pyarrow", "pandas"] | |||
daft = ["getdaft>=0.2.12"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Poetry you need to define daft
as a requirement above, and you can reference it here. Does Daft ship with PyArrow by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Daft does define a transitive dependency on pyarrow!
Should we also have some sanity checks, for example:
|
We could either do this in this PR, or as a follow-up. Let me know your preference! I have some tests written up, but am having some trouble starting the dev environment locally. Is
|
@jaychia Recently Hive integration tests have been added. First, you want to make sure that you're on a recent version of Docker. Also, it is good to periodically run |
daft
, so thatpip install pyiceberg[daft]
will pull Daft in as a dependencyTable.to_daft()
method to convert a table into a Daft dataframe