Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message in case of a mismatch #352

Merged
merged 9 commits into from
Feb 25, 2024
Merged

Improve error message in case of a mismatch #352

merged 9 commits into from
Feb 25, 2024

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Feb 1, 2024

No description provided.

HonahX
HonahX reviewed Feb 2, 2024
View reviewed changes
Copy link
Contributor

@HonahX HonahX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Fokko! Just have 2 small question.

HonahX
HonahX approved these changes Feb 4, 2024
View reviewed changes
Copy link
Contributor

@HonahX HonahX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is good to go when CI pass. Thanks!

Fokko and others added 2 commits February 5, 2024 20:50
@Fokko @HonahX
Property
e0afd81 
Co-authored-by: Honah J. <[email protected]>
@Fokko @HonahX
Property
ca7f832 
Co-authored-by: Honah J. <[email protected]>
@Fokko
Copy link
Contributor Author

Fokko commented Feb 5, 2024

@HonahX Thanks 🙏

@Fokko Fokko added this to the PyIceberg 0.7.0 release milestone Feb 7, 2024
@Fokko Fokko merged commit 339ba53 into apache:main Feb 25, 2024
6 checks passed
@Fokko Fokko deleted the fd-nice-error branch February 25, 2024 22:33
himadripal pushed a commit to himadripal/iceberg-python that referenced this pull request Mar 1, 2024
@Fokko @HonahX
Improve error message in case of a mismatch (apache#352)
b58e9ec 
* Nice error

* Simplify a bit

* Property

Co-authored-by: Honah J. <[email protected]>

* Property

Co-authored-by: Honah J. <[email protected]>

* Whitespace

---------

Co-authored-by: Honah J. <[email protected]>
HonahX pushed a commit to HonahX/iceberg-python that referenced this pull request Mar 29, 2024
@Fokko @HonahX
Improve error message in case of a mismatch (apache#352)
c0c0e79 
Backport to 0.6.1
This was referenced Mar 29, 2024
Merged
Merged
HonahX added a commit that referenced this pull request Mar 31, 2024
@HonahX @Fokko
Improve error message in case of a mismatch (#352) (#560)
b9362ee 
Backport to 0.6.1

Co-authored-by: Fokko Driesprong <[email protected]>
@Fokko Fokko mentioned this pull request May 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HonahX HonahX HonahX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
PyIceberg 0.6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Fokko @HonahX