Allow filtering on newly added columns #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh-jahagirdar
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Some questions, but nothing that I think is blocking, thanks @Fokko !
pyiceberg/expressions/visitors.py
Outdated
Comment on lines
912
to
916
| if "Not found in file schema" in str(e): | ||
| if isinstance(expr, BoundIsNull): | ||
| return AlwaysTrue() | ||
| else: | ||
| return AlwaysFalse() |
There was a problem hiding this comment.
Curious, why not do this in the visitor itself (_ColumnNameTranslator#visit_bound_predicate)? Is it something we would want decoupled from it?
There was a problem hiding this comment.
I actually like that more, great suggestion 👍
Comment on lines
+384
to
+385
| arrow_table = test_table_add_column.scan(row_filter="b == '2'").to_arrow() | ||
| assert arrow_table["b"].to_pylist() == ['2'] |
There was a problem hiding this comment.
As a sanity check should we add a test which validates that a row_filter='b is NOT NULL' returns the same?
There was a problem hiding this comment.
That's a good one, added 👍
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Jan 13, 2024
* Allow filtering on newly added columns Resolves apache#217 * Thanks Amogh!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #217