Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to set hoodie configs figs for Compactor, Cleaner and HDFSParquetImporter utility scripts #691

Merged
merged 1 commit into from
May 24, 2019

Conversation

bvaradar
Copy link
Contributor

Allow users to set hoodie configs figs for Compactor, Cleaner and HDFSParquetImporter utility scripts

@bvaradar
Copy link
Contributor Author

There is a follow-up newbie task to add the options in CLI. https://issues.apache.org/jira/browse/HUDI-118

@bvaradar bvaradar requested review from vinothchandar and n3nash May 23, 2019 23:45
@bvaradar
Copy link
Contributor Author

@n3nash @vinothchandar

@n3nash : This is a minor issue reported in channel. Can you take a look and review. If it looks good, should be safe enough to be added before next release.


public HDFSParquetImporter(Config cfg) throws IOException {
this.cfg = cfg;
this.props = cfg.propsFilePath == null ? UtilHelpers.buildProperties(cfg.configs) :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is cfg.configs ?

@n3nash n3nash self-requested a review May 24, 2019 00:35
@n3nash n3nash merged commit 2fe526d into apache:master May 24, 2019
nsivabalan pushed a commit to nsivabalan/hudi that referenced this pull request May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants