[HUDI-4920] fix PartialUpdatePayload cannot return deleted record in … #6799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengjian428
force-pushed
the
HUDI-4920
branch
from
2004f89 to
893c80d
Compare
nsivabalan
added
the
priority:major
nsivabalan
reviewed
Oct 20, 2022
|
bvaradar
requested changes
Feb 22, 2023
hudi-common/src/main/java/org/apache/hudi/common/model/PartialUpdateAvroPayload.java
Outdated
Show resolved
Hide resolved
bvaradar
requested changes
Apr 4, 2023
hudi-common/src/main/java/org/apache/hudi/common/model/PartialUpdateAvroPayload.java
Outdated
Show resolved
Hide resolved
hudi-common/src/test/java/org/apache/hudi/common/model/TestPartialUpdateAvroPayload.java
Show resolved
Hide resolved
|
LGTM. Will approve once the test passes and I make a final pass. |
|
@fengjian428 : Can you rebase against latest master and also check the failing test. |
fengjian428
force-pushed
the
HUDI-4920
branch
4 times, most recently
from
b828393 to
4468648
Compare
added 2 commits
April 6, 2023 00:48
done |
|
@hudi-bot run azure |
@bvaradar fixed |
bvaradar
approved these changes
Apr 22, 2023
|
@hudi-bot run azure |
yihua
pushed a commit
to yihua/hudi
that referenced
this pull request
May 15, 2023
apache#6799) Co-authored-by: fengjian <[email protected]>
yihua
pushed a commit
to yihua/hudi
that referenced
this pull request
May 15, 2023
apache#6799) Co-authored-by: fengjian <[email protected]>
yihua
pushed a commit
to yihua/hudi
that referenced
this pull request
May 17, 2023
apache#6799) Co-authored-by: fengjian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
fix PartialUpdatePayload cannot return deleted record in preCombine function issue
Impact
minor
Risk level (write none, low medium or high below)
low
Contributor's checklist