Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-4763] Allow hoodie read client to choose index #6506

Merged
merged 3 commits into from
Sep 10, 2022
Merged

[HUDI-4763] Allow hoodie read client to choose index #6506

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ddd6bc
Provide constructor to use choose index type
parisni Aug 25, 2022
5e2d1f0
Fmt
parisni Aug 25, 2022
fe10e3c
Addres review comments
yihua Sep 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/HoodieReadClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,20 @@ public HoodieReadClient(HoodieSparkEngineContext context, String basePath, SQLCo
this.sqlContextOpt = Option.of(sqlContext);
}

/**
* Initializes the {@link HoodieReadClient} with engine context, base path, SQL context and index type.
*
* @param context Hudi Spark engine context
* @param basePath Base path of the table
* @param sqlContext {@link SQLContext} instance
* @param indexType Hudi index type
*/
public HoodieReadClient(HoodieSparkEngineContext context, String basePath, SQLContext sqlContext, HoodieIndex.IndexType indexType) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to be used in any query engine?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use this client in our custom code. AFAIK this is the only way to benefit from bloom indexes while reading a hudi table. Then both global bloom / bloom are useful

this(context, HoodieWriteConfig.newBuilder().withPath(basePath)
.withIndexConfig(HoodieIndexConfig.newBuilder().withIndexType(indexType).build()).build());
this.sqlContextOpt = Option.of(sqlContext);
}

/**
* @param clientConfig instance of HoodieWriteConfig
*/
Expand Down