Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes HUDI-9 : Check precondition minInstantsToKeep > cleanerCommitsR… #617

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Fixes HUDI-9 : Check precondition minInstantsToKeep > cleanerCommitsR… #617

merged 1 commit into from
Mar 27, 2019

Conversation

vinothchandar
Copy link
Member

…etained

  • Added a precondition check, otherwise incr pull could miss commits
  • Lowered default cleaner retention to 10, to enable simpler understanding for newbies
  • Bumped down min/max instants to retain as well

Fixes HUDI-9 : Check precondition minInstantsToKeep > cleanerCommitsR…
6f638ac 
…etained

 - Added a precondition check, otherwise incr pull could miss commits
 - Lowered default cleaner retention to 10, to enable simpler understanding for newbies
 - Bumped down min/max instants to retain as well
@vinothchandar vinothchandar force-pushed the hudi-9-validate-min-commits-retained branch from fba9555 to 6f638ac Compare March 27, 2019 05:51
bvaradar
bvaradar approved these changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@bvaradar bvaradar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

vinothchandar
vinothchandar commented Mar 27, 2019
View reviewed changes
hoodie-client/src/main/java/com/uber/hoodie/config/HoodieCompactionConfig.java
private static final String DEFAULT_CLEANER_COMMITS_RETAINED = "24";
private static final String DEFAULT_MAX_COMMITS_TO_KEEP = String.valueOf(128);
private static final String DEFAULT_MIN_COMMITS_TO_KEEP = String.valueOf(96);
private static final String DEFAULT_CLEANER_COMMITS_RETAINED = "10";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@n3nash once you are happy with defaults, I ll merge

n3nash
n3nash approved these changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@n3nash n3nash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, in komondor we are overriding these values, as you said, let's make it clear in the release notes so there is no confusion.

@vinothchandar vinothchandar merged commit 372fbc4 into apache:master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n3nash n3nash n3nash approved these changes

@bvaradar bvaradar bvaradar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinothchandar @n3nash @bvaradar