Add compression codec configurations for HoodieParquetWriter. #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,6 +44,9 @@ | |||
| public static final String PARQUET_COMPRESSION_RATIO = "hoodie.parquet.compression.ratio"; | |||
| // Default compression ratio for parquet | |||
| public static final String DEFAULT_STREAM_COMPRESSION_RATIO = String.valueOf(0.1); | |||
| public static final String PARQUET_COMPRESSION_CODEC = "hoodie.parquet.compression.codec"; | |||
| // Default compression ratio for parquet | |||
| public static final String DEFAULT_STREAM_COMPRESSION_CODEC = "gzip"; | |||
There was a problem hiding this comment.
nit: consistently name to `DEFAULT_PARQUET_COMPRESSION_CODEC" ?
There was a problem hiding this comment.
I will change it, thx.
|
@vinothchandar Where is configurations.md? |
|
https://hudi.apache.org/contributing.html#website talks about this.. its on the asf-site branch.. under |
kaka11chen
force-pushed
the
add-parquet-compression-codec-conf#77
branch
from
896a9c5 to
81766e7
Compare
|
@vinothchandar Thanks, will add document tomorrow. |
n3nash
approved these changes
Mar 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add compression codec configurations for HoodieParquetWriter
("hoodie.parquet.compression.codec" : "gzip" / "snappy" / "uncompressed" / "lzo")
https://issues.apache.org/jira/browse/HUDI-77