Fixing small file handling, inline compaction defaults #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vinothchandar
commented
Mar 12, 2019
vinothchandar
commented
- This is causing poor out-of-box experience
- Fixed small issue with quickstart
vinothchandar
changed the title
vinothchandar
changed the title
vinothchandar
changed the title
n3nash
reviewed
Apr 1, 2019
hoodie-client/src/main/java/com/uber/hoodie/config/HoodieCompactionConfig.java
Show resolved
Hide resolved
n3nash
reviewed
Apr 1, 2019
|
Couple of minor comments, rest looks good, can approve once addressed |
- Small file limit is now 100MB by default - Turned on inline compaction by default for MOR - Changes take effect on DataSource and DeltaStreamer
|
@n3nash addressed other issue.. Please merge after you take a pass and CI passes |
n3nash
approved these changes
Apr 2, 2019
|
I think I resolved both your comments? @n3nash did I miss something? I added the comment to denoet the actual MB value |
|
I think repush got rid of it.. fished it out of email notification
its done internally by write client. we'd have to introduce a config and introduce a sleep in there? Alternatively, have to try mock some method intelligently.. Does not seem worth the trouble. thoughts? |
|
Yeah, good for now, we anyways have to solve this in general for all tests. |
vinishjail97
pushed a commit
to vinishjail97/hudi
that referenced
this pull request
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.