Filtering partition paths before performing a list status on all partitions #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
| * @param partitionPaths | ||
| * @return | ||
| */ | ||
| public List<String> filter(HoodieWriteConfig writeConfig, List<String> partitionPaths) { |
There was a problem hiding this comment.
can we name this better? filterPartitionPaths?
| /** | ||
| * Filter the partition paths based on compaction strategy | ||
| * @param writeConfig | ||
| * @param partitionPaths |
There was a problem hiding this comment.
name this allPartitionPaths?
n3nash
force-pushed
the
reduce_list_status
branch
from
d8b39bf to
d5085ab
Compare
|
addressed comments |
n3nash
force-pushed
the
reduce_list_status
branch
from
d5085ab to
f5e6e7d
Compare
vinishjail97
pushed a commit
to vinishjail97/hudi
that referenced
this pull request
Feb 16, 2024
Co-authored-by: Jonathan Vexler <=>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses : #536