Avoid WriteStatus collect() call when committing batch to prevent Driver side OOM errors #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vinothchandar @n3nash : Please review when you get a chance. |
vinothchandar
approved these changes
Nov 28, 2018
| //TODO: why is stat.getPartitionPath() null at times here. | ||
| metadata.addWriteStat(status.getPartitionPath(), stat); | ||
| metadata.addWriteStat(partitionPath, stat); |
There was a problem hiding this comment.
I remember running into some weird test fail when getting the partition path from the stat?
| @@ -127,6 +127,7 @@ private void init(HoodieRecord record) { | |||
| writeStatus.getStat().setPrevCommit(baseInstantTime); | |||
| writeStatus.setFileId(fileId); | |||
| writeStatus.setPartitionPath(partitionPath); | |||
| writeStatus.getStat().setPartitionPath(partitionPath); | |||
vinishjail97
pushed a commit
to vinishjail97/hudi
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WriteStatus has references to failed and written HoodieRecords. So, collecting them in driver will cause OOM errors for large batches. This PR removes calling collect of WriteStatus RDD and instead collects only File stats for the affected files.
Note that this PR does not address executor side overhead for retaining individual records in WriteStatus