Fix addMetadataFields() to carry over 'props'

[shangxinli]

#483

[CLAassistant]

All committers have signed the CLA.

[vinothchandar]

can we add a unit test or add a check to an existing test confirming props are carried over.. Given a large reliance on this, I think its best to do this before checking in

[vinothchandar]

lg otherwise

[n3nash]

@shangxinli As @vinothchandar mentioned, could we add a check (in a test) and confirm that the props are carried over ?

[shangxinli]

I am working on it. It is almost done but I got a lot of meetings today. So I will send the test soon.

On Thu, Oct 18, 2018 at 4:17 PM n3nash ***@***.***> wrote: @shangxinli <https://github.com/shangxinli> As @vinothchandar <https://github.com/vinothchandar> mentioned, could we add a check (in a test) and confirm that the props are carried over ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#484 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Ad91MUOoRf6_zKol3RqoIMywAaklJNDFks5umQv0gaJpZM4XYYD-> .

-- Xinli Shang

[shangxinli]

Added unit test

[n3nash]

nit-> 2016/2018

[n3nash]

@shangxinli one minor comment, rest looks good.

[bvaradar]

Rest looks good.

[vinothchandar]

@shangxinli can you address the minor ones. we can merge thereafter

[vinothchandar]

@shangxinli please squash your commits as well into one