Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --filter-dupes to DeltaStreamer #478

Merged
merged 1 commit into from
Oct 4, 2018
Merged

Add --filter-dupes to DeltaStreamer #478

merged 1 commit into from
Oct 4, 2018

Conversation

vinothchandar
Copy link
Member

  • Optionally filter out duplicates before inserting data
  • Unit tests

Add --filter-dupes to DeltaStreamer
8e5af71 
 - Optionally filter out duplicates before inserting data
 - Unit tests
vinothchandar
vinothchandar commented Oct 3, 2018
View reviewed changes
hoodie-spark/src/main/java/com/uber/hoodie/DataSourceUtils.java
@@ -142,4 +143,19 @@ public static HoodieRecord createHoodieRecord(GenericRecord gr, Comparable order
HoodieRecordPayload payload = DataSourceUtils.createPayload(payloadClass, gr, orderingVal);
return new HoodieRecord<>(hKey, payload);
}

@SuppressWarnings("unchecked")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leletan I reused your method here.. if I land first, then you can just add a new overload that takes parameters and call this..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinothchandar Ack. Thanks for letting me know

bvaradar
bvaradar approved these changes Oct 3, 2018
View reviewed changes
Copy link
Contributor

@bvaradar bvaradar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@vinothchandar vinothchandar merged commit 1fca9b2 into apache:master Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leletan leletan leletan left review comments

@bvaradar bvaradar bvaradar approved these changes

@n3nash n3nash Awaiting requested review from n3nash

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinothchandar @bvaradar @leletan