BUGFIX - Use Guava Optional (which is Serializable) in CompactionOperation to avoid NoSerializableException #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation wcached to avoid NoSerializableException
|
I am of similar opinion that we should move java.util.Optional to Guava Optional. As long as no client facing API's / payloads required java optional, this change should not affect anyone. This diff LGTM |
vinishjail97
pushed a commit
to vinishjail97/hudi
that referenced
this pull request
Dec 15, 2023
…he#435) Signed-off-by: Lokesh Jain <[email protected]> Co-authored-by: Shiyan Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CompactionOperation uses java.util.Optional which is not serializable.
Making kryo serializer work with java.util.Optional involves implementing a custom serializer (https://stackoverflow.com/questions/36144618/spark-kryo-register-a-custom-serializer). With Hoodie being a library, this option may not be a generic one.
Instead of java.util.Optional , we can use Guava's version of Optional which is serializable. This PR makes changes only to CompactionOperation class. If everybody is ok with this, we can make one pass in separate PR to replace java.util.Optional with Guava's Optional.
@vinothchandar @n3nash : Please review this