Changing access level to protected so that subclasses can access it #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@vinothchandar @bvaradar @n3nash @jianxu Can one of you please look at it? |
bvaradar
reviewed
Jul 16, 2018
| @@ -45,8 +45,8 @@ | |||
|
|
|||
| private HoodieWriteStat stat = null; | |||
|
|
|||
| private long totalRecords = 0; | |||
| private long totalErrorRecords = 0; | |||
| protected long totalRecords = 0; | |||
There was a problem hiding this comment.
Can you add setters for these 2 attributes instead of changing access restrictions ?
There was a problem hiding this comment.
so add both setters and getters? LGTM.
|
@bvaradar updated diff. |
bvaradar
reviewed
Jul 17, 2018
| @@ -31,11 +31,11 @@ | |||
| */ | |||
| public class WriteStatus implements Serializable { | |||
|
|
|||
| private final HashMap<HoodieKey, Throwable> errors = new HashMap<>(); | |||
| protected final HashMap<HoodieKey, Throwable> errors = new HashMap<>(); | |||
There was a problem hiding this comment.
Do you still need protected access ? These container attributes have getters with which you can update the container ?
|
LGTM otherwise. |
bvaradar
approved these changes
Jul 18, 2018
|
Thank you all. |
vinishjail97
pushed a commit
to vinishjail97/hudi
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use custom implementations of WriteStatus for overriding markSuccess() and markFailure() methods. But we don't want to override all the other methods and would want to reuse existing data-structures. This change is only changing the access level for these data members.