-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deprecated hash function #259
Update deprecated hash function #259
Conversation
Guava deprecated hashString(String) in v15, and removed it in v16. Replace call with hashUnencodedString(String), which replace it, to be compatible with newer versions of Guava.
@vinothchandar , @n3nash FYI. |
Happy to pull this.. but fyi
|
I am afraid we have a problem. Spark is still on 14.0 and a job fails as below.
I am going to revert this change. Can you comment on how you got this tested? I am using Spark 2.1 |
@esmioley ^^ |
We're using a spark build running with guava 16 (which is why it was failing in the first place, requiring a change) |
when you say spark build, is this our own spark library build or final jar given to spark-submit has guava 16. |
Co-authored-by: Y Ethan Guo <[email protected]> Co-authored-by: 苏承祥 <[email protected]> Co-authored-by: 苏承祥 <[email protected]> Co-authored-by: Danny Chan <[email protected]> Co-authored-by: Alexey Kudinkin <[email protected]> Co-authored-by: harshal <[email protected]> Co-authored-by: Pramod Biligiri <[email protected]> Co-authored-by: huangxiaoping <[email protected]> Co-authored-by: Teng <[email protected]> Co-authored-by: zhuanshenbsj1 <[email protected]> Co-authored-by: Rahil C <[email protected]> Co-authored-by: Rahil Chertara <[email protected]> Co-authored-by: Balaji Varadarajan <[email protected]> Co-authored-by: Nicholas Jiang <[email protected]> Co-authored-by: Sagar Sumit <[email protected]> Co-authored-by: sandyfog <[email protected]> Co-authored-by: Shiyan Xu <[email protected]> Co-authored-by: Manu <[email protected]> Co-authored-by: Bingeng Huang <[email protected]> Co-authored-by: hbg <[email protected]> Co-authored-by: Tim Brown <[email protected]> Co-authored-by: Lokesh Jain <[email protected]> Co-authored-by: rfyu <[email protected]> Co-authored-by: Raymond Xu <[email protected]>
Guava deprecated hashString(String) in v15, and removed it in v16.
Replace call with hashUnencodedString(String), which replace it, to
be compatible with newer versions of Guava.