fix for cleaning log files in master branch (mor) #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n3nash
changed the title
vinishjail97
pushed a commit
to vinishjail97/hudi
that referenced
this pull request
Dec 15, 2023
Cherry-picking commits for upcoming release onehouseinc/hudi-internal@cb96ba6 onehouseinc/hudi-internal@b840f6f onehouseinc/hudi-internal@8383d38 onehouseinc/hudi-internal@35c2553 onehouseinc/hudi-internal@cb434e1 apache@6f6652a apache@1d28d51 apache@fc1831b apache@3a08bdc apache@1d28d51 apache@98643c6 apache@5acc6fe apache@1cc6442 apache@22eab39 apache@3e1171c apache@4609ed1 apache@1cb8ffe apache@4fd3ff3 apache@b162330 Co-authored-by: Y Ethan Guo <[email protected]> Co-authored-by: Sagar Sumit <[email protected]> Co-authored-by: Alexander Trushev <[email protected]> Co-authored-by: Rahil C <[email protected]> Co-authored-by: Rahil Chertara <[email protected]> Co-authored-by: Alexey Kudinkin <[email protected]> Co-authored-by: BruceLin <[email protected]> Co-authored-by: Jon Vexler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vinothchandar Used FileGroups abstraction to fix the clean() API for merge on read tabletype. We need a refactor to move this logic into each table so that MOR clean logic isn't part of COW. The scope of that issue is different and will do it as part of a different PR.
Once you review this, #217 PR can be closed.