Correct clean bug that causes exception when partitionPaths are empty #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prazanna
suggested changes
Jun 20, 2017
| try { | ||
| List<String> partitionsToClean = | ||
| FSUtils.getAllPartitionPaths(getFs(), getMetaClient().getBasePath(), config.shouldAssumeDatePartitioning()); | ||
| logger.info("Partitions to clean up : " + partitionsToClean + ", with policy " + config | ||
| .getCleanerPolicy()); | ||
| partitionCleanStats = cleanPartitionPaths(partitionsToClean, jsc); | ||
| if (partitionsToClean.isEmpty()) { | ||
| logger.info("Nothing to clean here mom. It is already clean"); | ||
| return partitionCleanStats; |
There was a problem hiding this comment.
return Lists.newArrayList()
| @@ -492,17 +492,17 @@ protected HoodieUpdateHandle getUpdateHandle(String commitTime, String fileLoc, | |||
| */ | |||
| @Override | |||
| public List<HoodieCleanStat> clean(JavaSparkContext jsc) { | |||
| List<HoodieCleanStat> partitionCleanStats; | |||
| List<HoodieCleanStat> partitionCleanStats = Collections.emptyList(); | |||
There was a problem hiding this comment.
Remove this and return empty list when there is nothing to clean
| if (partitionsToClean.isEmpty()) { | ||
| logger.info("Nothing to clean here mom. It is already clean"); | ||
| return partitionCleanStats; | ||
| } | ||
| partitionCleanStats = cleanPartitionPaths(partitionsToClean, jsc); |
kaushikd49
force-pushed
the
bug/issue_200
branch
from
8d4ab73 to
8e991b0
Compare
|
Updated the PR Prasanna. |
prazanna
approved these changes
Jun 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #200
Corrected logic and added a test to detect the bug.