[HUDI-7624] Fixing source read and index tagging duration #12789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rajesh Mahindra <[email protected]>
danny0405
reviewed
Feb 6, 2025
| @@ -161,13 +166,14 @@ public HoodieWriteMetadata<HoodieData<WriteStatus>> execute(HoodieData<HoodieRec | |||
| HoodieData<HoodieRecord<T>> inputRecordsWithClusteringUpdate = clusteringHandleUpdate(inputRecords); | |||
|
|
|||
| context.setJobStatus(this.getClass().getSimpleName(), "Building workload profile:" + config.getTableName()); | |||
| HoodieTimer sourceReadAndIndexTimer = HoodieTimer.start(); // time taken from dedup -> tag location -> building workload profile | |||
| WorkloadProfile workloadProfile = | |||
There was a problem hiding this comment.
The new changes just initializes the timer on the fly and passed in, why not just move the timer at line 164 to the begining of the method?
There was a problem hiding this comment.
I moved it to the beginning of
BaseWriteHelper.write
There was a problem hiding this comment.
Looks much better now, just a minor comment: in base executor the execute(I inputRecords, Option<HoodieTimer> preWriteTimer) invokes execute(I inputRecords) but in it's Spark impl it's the other way around, this is kind of tricky.
nsivabalan
commented
Feb 10, 2025
| @@ -161,13 +166,14 @@ public HoodieWriteMetadata<HoodieData<WriteStatus>> execute(HoodieData<HoodieRec | |||
| HoodieData<HoodieRecord<T>> inputRecordsWithClusteringUpdate = clusteringHandleUpdate(inputRecords); | |||
|
|
|||
| context.setJobStatus(this.getClass().getSimpleName(), "Building workload profile:" + config.getTableName()); | |||
| HoodieTimer sourceReadAndIndexTimer = HoodieTimer.start(); // time taken from dedup -> tag location -> building workload profile | |||
| WorkloadProfile workloadProfile = | |||
There was a problem hiding this comment.
I moved it to the beginning of
BaseWriteHelper.write
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Fixing source read and index tagging duration.
Rational for test failure:
Apparently HoodieWriteHelper is singleton. and we might keep reusing the same instance for all writers (when multi-writers). So, the sourceReadAndIndexTaggingTimer which tracks the sourceReadAndIndexTagging duration could be started -> and then stopped -> and then again stopped. Had to fix that and move one layer up where we HoodieTimer.start() is called for every batch of write.
Impact
Fixing source read and index tagging duration.
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist