Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose rocksdb background jobs option #812

Merged
merged 6 commits into from
Apr 7, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Apr 7, 2023

Which issue does this PR close?

Closes #

Rationale for this change

Max background jobs is hard-code, expose an option to configure this.

What changes are included in this PR?

  • Add new options for background jobs.
  • Add new http endpoint for debugging GET /debug/stats, this require following config:
[analytic.wal.data_namespace]
enable_statistics = true
max_background_jobs = 8

image

Are there any user-facing changes?

No

How does this change test

No need.

@codecov-commenter
Copy link

Codecov Report

Merging #812 (6b47fb8) into main (d9b7d15) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 6b47fb8 differs from pull request most recent head 4ddb0ac. Consider uploading reports for the commit 4ddb0ac to get more accurate results

@@            Coverage Diff             @@
##             main     #812      +/-   ##
==========================================
- Coverage   67.99%   67.99%   -0.01%     
==========================================
  Files         299      299              
  Lines       47174    47173       -1     
==========================================
- Hits        32077    32075       -2     
- Misses      15097    15098       +1     
Impacted Files Coverage Δ
analytic_engine/src/lib.rs 98.86% <100.00%> (+0.05%) ⬆️
analytic_engine/src/manifest/details.rs 95.62% <100.00%> (-0.01%) ⬇️
analytic_engine/src/setup.rs 56.00% <100.00%> (ø)
wal/src/rocks_impl/manager.rs 91.06% <100.00%> (-0.07%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 added this pull request to the merge queue Apr 7, 2023
Merged via the queue into apache:main with commit af93b46 Apr 7, 2023
@jiacai2050 jiacai2050 deleted the feat-rocksdb-config branch April 7, 2023 08:08
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* feat: expose rocksdb background jobs option

* fix clippy

* fix CR

* add stats endpoint

* fix clippy

* add missing files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants