Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: http query with proxy #807

Merged
merged 7 commits into from
Apr 12, 2023
Merged

feat: http query with proxy #807

merged 7 commits into from
Apr 12, 2023

Conversation

chunshao90
Copy link
Contributor

@chunshao90 chunshao90 commented Apr 5, 2023

Which issue does this PR close?

Closes #

Rationale for this change

Support forward http sql query.

What changes are included in this PR?

  • Impl http sql query with proxy.
  • Forward http sql query.

Are there any user-facing changes?

Support forward http sql query.

How does this change test

Manual testing and CI.

@codecov-commenter
Copy link

Codecov Report

Merging #807 (af64eb9) into main (9976a6f) will decrease coverage by 0.25%.
The diff coverage is 1.86%.

❗ Current head af64eb9 differs from pull request most recent head 7ebd9a2. Consider uploading reports for the commit 7ebd9a2 to get more accurate results

@@            Coverage Diff             @@
##             main     #807      +/-   ##
==========================================
- Coverage   68.20%   67.96%   -0.25%     
==========================================
  Files         295      296       +1     
  Lines       46823    46954     +131     
==========================================
- Hits        31937    31910      -27     
- Misses      14886    15044     +158     
Impacted Files Coverage Δ
server/src/grpc/mod.rs 0.00% <0.00%> (ø)
server/src/handlers/query.rs 0.00% <ø> (ø)
server/src/http.rs 0.00% <0.00%> (ø)
server/src/proxy/grpc/write.rs 36.57% <ø> (+2.19%) ⬆️
server/src/proxy/http/query.rs 0.00% <0.00%> (ø)
server/src/proxy/mod.rs 0.00% <0.00%> (ø)
server/src/server.rs 0.00% <0.00%> (ø)
server/src/proxy/forward.rs 79.84% <75.00%> (-0.08%) ⬇️

... and 11 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chunshao90 chunshao90 marked this pull request as ready for review April 11, 2023 10:04
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunshao90 chunshao90 added this pull request to the merge queue Apr 12, 2023
Merged via the queue into apache:main with commit 54735a7 Apr 12, 2023
chunshao90 added a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* feat: http query with proxy

* feat: support forward http sql query

* refactor code

* refactor by CR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants