refactor: use notifier::RequestNotifiers instead of dedup_requests::RequestNotifiers
#1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baojinri
force-pushed
the
refactor-dedup-request
branch
from
0842a25 to
0f86d97
Compare
baojinri
force-pushed
the
refactor-dedup-request
branch
from
0f86d97 to
2d73422
Compare
ShiKaiWi
reviewed
Oct 18, 2023
baojinri
force-pushed
the
refactor-dedup-request
branch
from
f3a1705 to
f75b87f
Compare
ShiKaiWi
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Now, there are same code of RequestNotifiers in notifier and dedup_requests, so we can use
notifier::RequestNotifiersinstead ofdedup_requests::RequestNotifiersDetailed Changes
notifier::RequestNotifiersinstead ofdedup_requests::RequestNotifiersdedup_requestsfileTest Plan
Existing tests