feat: improve query path observability #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiacai2050
reviewed
Oct 7, 2023
Rachelint
force-pushed
the
improve-query-observability
branch
from
c3aca57 to
d998798
Compare
jiacai2050
reviewed
Oct 8, 2023
This reverts commit 49c537d.
Rachelint
force-pushed
the
improve-query-observability
branch
from
14e66d0 to
b33df8a
Compare
Rachelint
added a commit
that referenced
this pull request
Oct 9, 2023
## Rationale Bug leading to logging nothing is introduced by pr #1235 , I fix it in this pr by overwritting `tag` default value to empty. ## Detailed Changes + Hide all detailed impl about logging in `logger` crate. + Overwrite default `tag` value(set by `log` crate) to empty. ## Test Plan Test manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Closes #1211
We have poor ways too observe query status, in this pr, a ton of tools are added for better observability.
Detailed Changes
query time range,sst prune rate,push down typeand so on...Test Plan
Test manually.