Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-28630: Upgrade ORC to 1.9.5 #5547

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dongjoon-hyun
Copy link
Member

What changes were proposed in this pull request?

This PR aims to upgrade ORC to 1.9.5.

Why are the changes needed?

To bring the latest bug fixes:

Does this PR introduce any user-facing change?

No.

Is the change a dependency upgrade?

Yes.

How was this patch tested?

Pass the CIs.

@dongjoon-hyun
Copy link
Member Author

It seems that I cannot see the CI log. Is there a way to check the failure?

Screenshot 2024-11-15 at 14 58 25

@zhangbutao
Copy link
Contributor

@dongjoon-hyun You can login in the jenkins web-ui by the top right button:
hive-jenkins

I can see the following failed tests:
failed-tests

testRebalanceCompactionWithParallelDeleteAsSecondPessimisticLock – org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez shows the following error stacktrace:

java.lang.AssertionError: unbalanced bucket 0 expected:<[{"writeid":1,"bucketid":536870912,"rowid":0}	5	4, {"writeid":1,"bucketid":536870912,"rowid":1}	6	2, {"writeid":1,"bucketid":536870912,"rowid":2}	6	3, {"writeid":1,"bucketid":536870912,"rowid":3}	6	4, {"writeid":1,"bucketid":536870912,"rowid":4}	5	2, {"writeid":1,"bucketid":536870912,"rowid":5}	5	3, {"writeid":2,"bucketid":536870912,"rowid":0}	12	12, {"writeid":3,"bucketid":536870912,"rowid":0}	13	13, {"writeid":4,"bucketid":536870912,"rowid":0}	14	14, {"writeid":5,"bucketid":536870912,"rowid":0}	15	15, {"writeid":6,"bucketid":536870912,"rowid":0}	16	16, {"writeid":7,"bucketid":536870912,"rowid":0}	17	17]> but was:<[{"writeid":1,"bucketid":536870912,"rowid":0}	5	4, {"writeid":1,"bucketid":536870912,"rowid":1}	6	2, {"writeid":1,"bucketid":536870912,"rowid":2}	6	3, {"writeid":1,"bucketid":536870912,"rowid":3}	6	4, {"writeid":2,"bucketid":536870912,"rowid":0}	12	12, {"writeid":3,"bucketid":536870912,"rowid":0}	13	13, {"writeid":4,"bucketid":536870912,"rowid":0}	14	14, {"writeid":5,"bucketid":536870912,"rowid":0}	15	15, {"writeid":6,"bucketid":536870912,"rowid":0}	16	16, {"writeid":7,"bucketid":536870912,"rowid":0}	17	17]>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:120)
	at org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.prepareRebalanceTestData(TestCrudCompactorOnTez.java:552)
	at org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testRebalanceCompactionWithParallelDeleteAsSecond(TestCrudCompactorOnTez.java:117)
	at org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testRebalanceCompactionWithParallelDeleteAsSecondPessimisticLock(TestCrudCompactorOnTez.java:102)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
	at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:316)
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:240)
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:214)
	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:155)
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:385)
	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
	at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:507)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:495)

@dongjoon-hyun
Copy link
Member Author

Thank you, @zhangbutao !

@okumin
Copy link
Contributor

okumin commented Dec 10, 2024

@dongjoon-hyun Could you please check failing test cases and fix those problems? Please feel free to let us know if you have any questions. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants