Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-28224: Upgrade Orc version in Hive to 1.9.3 #5218

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

difin
Copy link
Contributor

@difin difin commented Apr 26, 2024

What changes were proposed in this pull request?

Upgrading Orc version in Hive to the latest version that supports Java 8 - 1.9.4

Why are the changes needed?

To keep the Orc version in Hive updated.

Does this PR introduce any user-facing change?

No

Is the change a dependency upgrade?

How was this patch tested?

Pre-commit testing

Copy link

sonarqubecloud bot commented Aug 1, 2024

@@ -1078,6 +1078,7 @@ public void nextVector(ColumnVector previousVector, boolean[] isNull, final int
FilterContext filterContext, ReadPhase readPhase) throws IOException {
if (vectors == null) {
super.nextVector(previousVector, isNull, batchSize, filterContext, readPhase);
previousVector.isRepeating = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dongjoon-hyun / @cxzl25 can you help confirm, hardcoding isRepeating here would be correct workaround for ORC-1741 & it won't lead to any other side affects?

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayushtkn ayushtkn merged commit 658a9bc into apache:master Aug 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants