Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve] Improve clickhouse monitor And Improve Pulsar monitor #2015

Merged
merged 4 commits into from
May 21, 2024
Merged

[Improve] Improve clickhouse monitor And Improve Pulsar monitor #2015

merged 4 commits into from
May 21, 2024

Conversation

zhangshenghang
Copy link
Member

@zhangshenghang zhangshenghang commented May 20, 2024 •
edited
Loading

What's changed?

    1. Improve Pulsar chart display
    1. Fix Clickhouse Monitor query results under different versions of limit 5 and limit 10 are different. Modify it to obtain monitoring content based on the indicator name
    • Problem reproduction：
      • Original documentation：
      • image
      • Clickhouse SQL returns the result，It is obvious that they are different
      • image
    1. Added Clickhouse common monitoring Metric

Checklist

@github-actions github-actions bot added doc Improvements or additions to documentation monitoring-template backend labels May 20, 2024
@tomsun28 tomsun28 added the good first pull request Good for newcomers label May 20, 2024
tomsun28
tomsun28 approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm!

@tomsun28 tomsun28 added the enhancement New feature or request label May 21, 2024
@tomsun28 tomsun28 merged commit d93963b into apache:master May 21, 2024
3 checks passed
@zhangshenghang zhangshenghang deleted the improve-clickhouse-monitor branch September 3, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
backend doc Improvements or additions to documentation enhancement New feature or request good first pull request Good for newcomers monitoring-template
Projects
Apache HertzBeat (Incubating)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhangshenghang @tomsun28