Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Support time calculation expressions. #2009

Merged
merged 7 commits into from
May 20, 2024
Merged

[feature] Support time calculation expressions. #2009

merged 7 commits into from
May 20, 2024

Conversation

LiuTianyou
Copy link
Contributor

What's changed?

  1. add time calculation expression utils and unit test.
  2. update openai monitoring template add time params.
  3. the http protocol collection type supports query parameter usage time calculation expressions.

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

I will add relevant documentation in the next PR

@tomsun28 tomsun28 added the good first pull request Good for newcomers label May 19, 2024
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍LGTM!

@tomsun28 tomsun28 merged commit f9a2d9a into apache:master May 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants