-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] add at function for wechat #1994
Conversation
@tomsun28 cr ,please |
...a/org/apache/hertzbeat/manager/component/alerter/impl/WeWorkRobotAlertNotifyHandlerImpl.java
Outdated
Show resolved
Hide resolved
...a/org/apache/hertzbeat/manager/component/alerter/impl/WeWorkRobotAlertNotifyHandlerImpl.java
Outdated
Show resolved
Hide resolved
Code checkstyle is failed, please refer to here and ensure it passes the local test first. |
...a/org/apache/hertzbeat/manager/component/alerter/impl/WeWorkRobotAlertNotifyHandlerImpl.java
Show resolved
Hide resolved
web-app/src/assets/i18n/en-US.json
Outdated
@@ -271,6 +271,7 @@ | |||
"alert.notice.type.wechat-id": "WeChat OPENID", | |||
"alert.notice.type.wework": "WeWork Robot", | |||
"alert.notice.type.wework-key": "WeWork Robot KEY", | |||
"alert.notice.type.wework-userId": "userId", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"alert.notice.type.wework-userId": "userId", | |
"alert.notice.type.wework-userId": "UserId", |
@@ -271,6 +271,7 @@ | |||
"alert.notice.type.wechat-id": "微信OPENID", | |||
"alert.notice.type.wework": "企业微信机器人", | |||
"alert.notice.type.wework-key": "企业微信机器人KEY", | |||
"alert.notice.type.wework-userId": "用户id", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi, the i18n zh-TW.json also need this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍👍
Added enterprise weChat robot @ function