Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] optimize DateUtil and add test case #1974

Merged
merged 7 commits into from
May 13, 2024

Conversation

yuluo-yx
Copy link
Contributor

What's changed?

  • Optimize DateUtil toolkit and add tests.
  • Make tool class constructor methods private, tool classes don't run being created objects and inheritance

3c0b6c0289ab51ae75f93d4338d13d82

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@ZY945
Copy link
Member

ZY945 commented May 13, 2024

You need to solve this problem to pass CI
image

@yuluo-yx
Copy link
Contributor Author

You need to solve this problem to pass CI image

done. please approve ci. tks

Copy link
Member

@ZY945 ZY945 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZY945 ZY945 merged commit a69d05a into apache:master May 13, 2024
3 checks passed
@yuluo-yx yuluo-yx deleted the 0513-yuluo/optimize branch July 6, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants