Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] fix ConnectionCommonCache possible npe #1959

Merged
merged 1 commit into from
May 11, 2024
Merged

[bugfix] fix ConnectionCommonCache possible npe #1959

merged 1 commit into from
May 11, 2024

Conversation

crossoverJie
Copy link
Member

@crossoverJie crossoverJie commented May 10, 2024 •
edited
Loading

What's changed?

The value may be null when addCache -> removeCache.

It can be reproduced in this unit test.

hertzbeat/collector/src/test/java/org/apache/hertzbeat/collector/collect/redis/RedisClusterCollectImplTest.java

Line 70 in 78ca5ae

void testCollect(){

Previously, because there was type checking, it did not trigger a npe.

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 merged commit 133a783 into apache:master May 11, 2024
3 checks passed
@tomsun28 tomsun28 added the good first pull request Good for newcomers label May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
backend collector good first pull request Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crossoverJie @tomsun28