Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix]Replace monitors to alert. #1954

Merged
merged 2 commits into from
May 10, 2024
Merged

[bugfix]Replace monitors to alert. #1954

merged 2 commits into from
May 10, 2024

Conversation

zqr10159
Copy link
Member

@zqr10159 zqr10159 commented May 9, 2024

What's changed?

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@zqr10159 zqr10159 requested a review from tomsun28 May 9, 2024 16:16
@github-actions github-actions bot added the webapp label May 9, 2024
tomsun28
tomsun28 approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@tomsun28 tomsun28 added the good first pull request Good for newcomers label May 10, 2024
@tomsun28 tomsun28 merged commit 93477a5 into master May 10, 2024
3 checks passed
@zqr10159 zqr10159 deleted the alert-export-i18n branch May 10, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
good first pull request Good for newcomers webapp
Projects
Apache HertzBeat (Incubating)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zqr10159 @tomsun28