Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] add test for NgqlCollectImpl #1953

Merged
merged 3 commits into from
May 10, 2024
Merged

[test] add test for NgqlCollectImpl #1953

merged 3 commits into from
May 10, 2024

Conversation

LiuTianyou
Copy link
Contributor

What's changed?

  1. add unit test for NgqlCollectImpl
  2. optimize the error message of nebulaGraph connection

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 added the good first pull request Good for newcomers label May 10, 2024
tomsun28
tomsun28 approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomsun28 tomsun28 merged commit 6931835 into apache:master May 10, 2024
3 checks passed
@LiuTianyou LiuTianyou deleted the test-ngql branch May 12, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
backend collector good first pull request Good for newcomers
Projects
Apache HertzBeat (Incubating)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LiuTianyou @tomsun28 @zqr10159