Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactoring] Inject a single instance of the data store #1944

Merged
merged 4 commits into from
May 9, 2024
Merged

[refactoring] Inject a single instance of the data store #1944

merged 4 commits into from
May 9, 2024

Conversation

xuziyang
Copy link
Contributor

@xuziyang xuziyang commented May 9, 2024 •
edited
Loading

What's changed?

  1. Inject a single instance of the data store
  2. give a warning at system startup if no historical data repository is configured

For more detail, please see: #1933

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@zqr10159 zqr10159 requested a review from tomsun28 May 9, 2024 09:00
@tomsun28 tomsun28 added the good first pull request Good for newcomers label May 9, 2024
tomsun28
tomsun28 approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomsun28 tomsun28 merged commit 9765e06 into apache:master May 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
backend good first pull request Good for newcomers
Projects
Apache HertzBeat (Incubating)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xuziyang @tomsun28