Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[type:bugfix] fix HTTP API bug #1895 #1909

Merged
merged 2 commits into from
May 4, 2024
Merged

[type:bugfix] fix HTTP API bug #1895 #1909

merged 2 commits into from
May 4, 2024

Conversation

Aias00
Copy link
Contributor

@Aias00 Aias00 commented May 4, 2024

What's changed?

fix HTTP API bug #1895

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 linked an issue May 4, 2024 that may be closed by this pull request
[BUG] HTTP API did not fill in non mandatory fields, but prompted an error #1895
Closed
1 task
tomsun28
tomsun28 approved these changes May 4, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomsun28 tomsun28 merged commit 7bc72c6 into apache:master May 4, 2024
3 checks passed
@Aias00 Aias00 deleted the bugfix/http_uri_bug branch July 24, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
backend bugfix collector good first pull request Good for newcomers
Projects
Apache HertzBeat (Incubating)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] HTTP API did not fill in non mandatory fields, but prompted an error
2 participants
@Aias00 @tomsun28