-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix when manager restart, collect register error #1896
Conversation
log.info("the collector {} is not online.", identity); | ||
boolean isChannelActive = this.manageServer.isChannelActive(identity); | ||
if (!isChannelActive) { | ||
this.manageServer.addChannel(identity, ctx.channel()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the collector is offline and re online throgh heartbeatProcessor, does we need add this.manageServer.getCollectorAndJobScheduler().collectorGoOnline(collector, collectorInfo);
to re-dispath current collect jobs.
hi, i think this bug is due code here
the
when the main server shutdown, the all collector status is online. And when the main server startup, first will set all collector status offline in database, but if the collector online request is before the init offline, the online request will be ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
What's changed?
#1709
Checklist
Add or update API