Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve] Refactor common cache code #1881

Merged
merged 2 commits into from
Apr 28, 2024
Merged

[improve] Refactor common cache code #1881

merged 2 commits into from
Apr 28, 2024

Conversation

crossoverJie
Copy link
Member

What's changed?

Motivation

The current version does not use generics, resulting in the need for forced type casting.

Because each collector is a singleton, member variables can be used to save its own cache.

In addition, ConnectionCommonCache can also be used as a basic component for other businesses to use.

Modifications

  • Both of ConnectionCommonCache's key and value use generics.
  • Using the constructor instead of the static method.

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@zqr10159 zqr10159 merged commit 5cdc0d5 into apache:master Apr 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zqr10159 zqr10159 zqr10159 approved these changes

Assignees
No one assigned
Labels
backend collector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crossoverJie @zqr10159