Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] trans and use assert #1841

Merged
merged 4 commits into from
Apr 25, 2024
Merged

[refactor] trans and use assert #1841

merged 4 commits into from
Apr 25, 2024

Conversation

dukbong
Copy link
Contributor

@dukbong dukbong commented Apr 25, 2024

What's changed?

  • Using the Assert.isTrue method
  • Translate Chinese into English

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 changed the title Trans & Use Assert [refactor] trans and use assert Apr 25, 2024
@tomsun28 tomsun28 requested a review from TJxiaobao April 25, 2024 07:38
TJxiaobao
TJxiaobao approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@TJxiaobao TJxiaobao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

@TJxiaobao TJxiaobao merged commit 49db98a into apache:master Apr 25, 2024
3 checks passed
@dukbong dukbong deleted the transAndAssert branch April 25, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TJxiaobao TJxiaobao TJxiaobao approved these changes

Assignees
No one assigned
Labels
backend collector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dukbong @TJxiaobao @tomsun28