Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] dns monitoring template add query class parameter #1825

Merged
merged 3 commits into from
Apr 23, 2024
Merged

[bugfix] dns monitoring template add query class parameter #1825

merged 3 commits into from
Apr 23, 2024

Conversation

LiuTianyou
Copy link
Contributor

What's changed?

  1. dns monitoring template add query class parameter about issue([BUG] The response status code returned by DNS monitoring is usually REFUSED or SERVFAIL. #1805 ).
  2. update help document for dns monitoring.
  3. add some compatibility processing. If the user uses an old version of the DNS monitoring template, the metrics can still be collected normally.

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@github-actions github-actions bot added doc Improvements or additions to documentation monitoring-template collector backend labels Apr 23, 2024
@tomsun28 tomsun28 added the good first pull request Good for newcomers label Apr 23, 2024
@tomsun28 tomsun28 self-requested a review April 23, 2024 15:52
@tomsun28 tomsun28 linked an issue Apr 23, 2024 that may be closed by this pull request
[BUG] The response status code returned by DNS monitoring is usually REFUSED or SERVFAIL. #1805
Closed
1 task
@tomsun28 tomsun28 added this to the 1.6.0 milestone Apr 23, 2024
tomsun28
tomsun28 approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍 LGTM thanks!

@tomsun28 tomsun28 merged commit 024152e into apache:master Apr 23, 2024
3 checks passed
@LiuTianyou LiuTianyou deleted the fix-1805 branch April 24, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
backend bugfix collector doc Improvements or additions to documentation good first pull request Good for newcomers monitoring-template
Projects
Apache HertzBeat (Incubating)
Status: Done
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

[BUG] The response status code returned by DNS monitoring is usually REFUSED or SERVFAIL.
2 participants
@LiuTianyou @tomsun28