Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] Add whitespace checkstyle #1824

Merged
merged 3 commits into from
Apr 23, 2024
Merged

[improve] Add whitespace checkstyle #1824

merged 3 commits into from
Apr 23, 2024

Conversation

crossoverJie
Copy link
Member

What's changed?

I noticed that the existing code does not use whitespace uniformly, so I added related checks.

It can make the source code more standardized and unified.

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

# Conflicts:
#	common/src/main/java/org/apache/hertzbeat/common/entity/manager/JsonLongListAttributeConverter.java
#	common/src/main/java/org/apache/hertzbeat/common/entity/manager/JsonStringListAttributeConverter.java
#	common/src/main/java/org/apache/hertzbeat/common/entity/manager/NoticeTemplate.java
@tomsun28 tomsun28 added the good first pull request Good for newcomers label Apr 23, 2024
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍LGTM thanks

@tomsun28 tomsun28 merged commit ab52a49 into apache:master Apr 23, 2024
3 checks passed
@crossoverJie crossoverJie deleted the checkstyle-whitespace branch April 24, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants