Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] change the warehouse properties the type to record #1806

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

xuziyang
Copy link
Contributor

What's changed?

The remaining class in WarehouseProperties (the store-related class type is already record), the type is changed to record
#1785

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

…ted class type is already record), the type is changed to record
@tomsun28 tomsun28 changed the title [refactor] The remaining class in WarehouseProperties (the store-related class type is already record), the type is changed to record [refactor] change the warehouse properties the type to record Apr 22, 2024
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomsun28 tomsun28 added the good first pull request Good for newcomers label Apr 22, 2024
@tomsun28 tomsun28 merged commit f1ed92a into apache:master Apr 22, 2024
3 checks passed
@xuziyang xuziyang deleted the refactor branch April 28, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

2 participants